Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43299 )
Change subject: soc/amd/picasso: Add controls for SMT and downcoring
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43299/1/src/soc/amd/picasso/chip.h
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/43299/1/src/soc/amd/picasso/chip.h@...
PS1, Line 101: downcore_mode
Add a comment that this uses values from enum downcore modes? Or probably just use: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43299
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91654817608ab62e4104959b8876333911b90175
Gerrit-Change-Number: 43299
Gerrit-PatchSet: 3
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 27 Jul 2020 20:43:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment