[coreboot-gerrit] Change in coreboot[master]: cpu/x86/mp_init: Fix false error message on parking APs twice

[Arthur Heymans (Code Review)]

Attention is currently required from: Nico Huber, Johnny Lin, Stefan Reinauer.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55071 )

Change subject: cpu/x86/mp_init: Fix false error message on parking APs twice
......................................................................

Patch Set 2:

(2 comments)

Patchset:

PS2:
> Why not fix the spurious call instead?

So mp_park_aps() is conditionally called in intel_txt_prepare_txt_env(). Guarding the call in arch_bootstate_coreboot_exit() would be more messy and boil down to the same.

File src/cpu/x86/mp_init.c:

https://review.coreboot.org/c/coreboot/+/55071/comment/dcb6ab66_e196a58e 
PS2, Line 1056: 		printk(BIOS_DEBUG, "%s: CPUs already parked\n", __func__);
> We know they had been, but what if they aren't anymore?

What do you mean? There is no code in coreboot to wake APs twice to get them in a ap_wait_for_instruction() state.