Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44355 )
Change subject: soc/intel/tigerlake: Allow fine grained control of S0iX states
......................................................................
Patch Set 5:
Patch Set 5: Code-Review-1
According to my prior comment, I do not believe this CL is necessary for my feature. I am delaying fully abandoning it, though, until I am sure.
In my opinion, it is better to keep all the FSP_S UPD updates within the SoC code and only touch soc_config from mainboard. Thus, let's add LpmStateDisableMask as you have in this CL. (In the follow-up CL, you will have to perform the config setting in a different place than it is currently done - I will post a comment there).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44355
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a0cf820e20961486813067c6945fe07bc4899f7
Gerrit-Change-Number: 44355
Gerrit-PatchSet: 5
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 14 Aug 2020 17:15:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment