Attention is currently required from: Martin L Roth, Maximilian Brune, Philipp Hug.
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81543?usp=email )
Change subject: Update opensbi submodule to upstream master branch
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
dying here:
745 if (scratch->fw_rw_offset == 0 ||
746 (scratch->fw_rw_offset & (scratch->fw_rw_offset - 1)) != 0) {
747 sbi_printf("%s: fw_rw_offset is not a power of 2 (0x%lx)\n",
748 __func__, scratch->fw_rw_offset);
749 return SBI_EINVAL;
because
(gdb) print/x scratch->fw_rw_offset
$11 = 0x60000
(gdb) print/x (scratch->fw_rw_offset & (scratch->fw_rw_offset - 1))
$12 = 0x40000
fragile code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81543?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I50ce0ba3b6409247a94b49565cc04454903e88d0
Gerrit-Change-Number: 81543
Gerrit-PatchSet: 4
Gerrit-Owner: ron minnich
rminnich@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Fri, 29 Mar 2024 20:15:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment