Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48346 )
Change subject: azalia: Make `set_bits` function non-static
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48346/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48346/4//COMMIT_MSG@7
PS4, Line 7: azalia: Make `set_bits` function non-static
:
: Rename it to `azalia_set_bits` as the function is n
add that change from the header (making non-static) in the body, too, please
Done
https://review.coreboot.org/c/coreboot/+/48346/4//COMMIT_MSG@11
PS4, Line 11:
add a reason
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48346
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff3520131ec7bc8554612969e3a2fe9cdbc9305e
Gerrit-Change-Number: 48346
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Dec 2020 18:03:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment