Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36346 )
Change subject: cbfs: read header offset as explicitly LE ......................................................................
cbfs: read header offset as explicitly LE
le32_to_cpu spits out uint32_t on BE targets, cast it.
Change-Id: Idc99b0c133faa2aa15d06f998e7371d332ffa490 Signed-off-by: Marty E. Plummer hanetzer@startmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36346 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/lib/cbfs.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c index 1e8a93f..9ac1bc0 100644 --- a/src/lib/cbfs.c +++ b/src/lib/cbfs.c @@ -302,7 +302,7 @@ if (rdev_readat(bdev, &rel_offset, offset, sizeof(int32_t)) < 0) return -1;
- offset = fmap_top + rel_offset; + offset = fmap_top + (int32_t)le32_to_cpu(rel_offset); if (rdev_readat(bdev, &header, offset, sizeof(header)) < 0) return -1;