Attention is currently required from: Martin Roth, Alexander Couzens.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51362 )
Change subject: util/genbuild_h: add support to print SOURCE_DATE_EPOCH
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Not _too_ happy about adding an option for that here (which will encourage adding all kinds of other options, yuck).
We sometimes parse stuff out of build.h, eg in src/arch/arm64/Makefile.inc:
BL31_MAKEARGS += BUILD_MESSAGE_TIMESTAMP='"$(shell sed -n 's/^.define COREBOOT_BUILD>.*"(.*)".*/\1/p' $(obj)/build.h)"'
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51362
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa79d3e7df8101a1ba1b37a361d8992f7eab2d52
Gerrit-Change-Number: 51362
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Tue, 06 Apr 2021 16:34:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment