[coreboot-gerrit] Change in coreboot[master]: arch/x86: Attempt to boot without postcar stage/phase

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34752 )

Change subject: arch/x86: Attempt to boot without postcar stage/phase
......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34752/6/src/arch/x86/c_start.S 
File src/arch/x86/c_start.S:

https://review.coreboot.org/c/coreboot/+/34752/6/src/arch/x86/c_start.S@19 
PS6, Line 19: #endif
> > Can't this be included below at line 45 unconditionally? That was my suggestion. […]

What I mean is add this stanza to line 45 and remove the conditional around _start and .globl _start. It would result in the following sequence:

.globl _start
_start:
.globl _start
_start:

If the assembler doesn't care then things just work. Does the above cause a compilation problem?

https://review.coreboot.org/c/coreboot/+/34752/8/src/arch/x86/exit_car.S 
File src/arch/x86/exit_car.S:

https://review.coreboot.org/c/coreboot/+/34752/8/src/arch/x86/exit_car.S@40 
PS8, Line 40: 	 * is enabled in c_start.S
loaded? you mean no segment selectors used?