Attention is currently required from: Ravi kumar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53902 )
Change subject: sc7280: Add PCIe RC driver in Coreboot ......................................................................
Patch Set 4:
(26 comments)
File src/soc/qualcomm/sc7280/include/soc/addressmap.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/4c0771f7_9a177c1e PS4, Line 68: #define PCIE1_MEM_SIZE 0x1fd00000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/0366db42_b5c806cd PS4, Line 69: #define PCIE_MEM_END 0x404fffff please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/9f71fc5b_aa559d4d PS4, Line 72: #define PCIE_1_QMP_PHY 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/f81ea59b_4c4bbe68 PS4, Line 76: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
File src/soc/qualcomm/sc7280/include/soc/pcie.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/5129c993_c1c26249 PS4, Line 18: #define DEV_ID_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/03979dd2_3ab7dcf0 PS4, Line 19: #define CLASS_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/2accf4af_a59c97c2 PS4, Line 20: #define HEADER_SZ 8 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/5fdc815c_8242236d PS4, Line 21: #define VEND_ID_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/0eb34f51_2a540065 PS4, Line 25: #define PCIE_CLASS 0x0a please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/6c5bb770_aaf25891 PS4, Line 26: #define PCI_MAX_DEV_FN 0x100 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/8e444d9c_49f8e797 PS4, Line 41: #define PCIE1_3x2_NUM_LANES 2 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/2524cc75_79d5fd43 PS4, Line 57: #define PERST_DELAY_US 1000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/0cb83d4e_28f4f536 PS4, Line 58: #define PCIE_MAX_BARS 6 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/a3dd35e2_e2d70b34 PS4, Line 154: #define PCIE1_QMP_PHY_PCS_COM 0x01C0EA00 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/6b834c67_0d31d574 PS4, Line 155: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/07ffacfe_6329f7ec PS4, Line 156: #define PCE1_QPHY_TX0 0x01C0E200 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/605823ef_fdb56a97 PS4, Line 157: #define PCE1_QPHY_RX0 0x01C0E400 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/7326d917_03edffb0 PS4, Line 169: #define PCIE_DEV_FUNC (dev,func) PCI_SLOT(devfn) | PCI_FUNC(devfn) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/bcf92768_ec7d7342 PS4, Line 169: #define PCIE_DEV_FUNC (dev,func) PCI_SLOT(devfn) | PCI_FUNC(devfn) Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/42c8e764_9e64b287 PS4, Line 188: #define PCIE_DEV(_bus, _dev, _fn) (0x80000000 | \ Macros with complex values should be enclosed in parentheses
File src/soc/qualcomm/sc7280/pcie_host.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/4a7632e0_1bc4a610 PS4, Line 303: pci_ep_cfg_info.config_base = (void*)PCIE1_GEN3x2_CONF; "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/b1fee5ea_cd0ca567 PS4, Line 459: printk(BIOS_INFO,"pcie ep PERST asserted \n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/b6982412_99c38399 PS4, Line 459: printk(BIOS_INFO,"pcie ep PERST asserted \n"); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/0c066195_0f104b77 PS4, Line 468: printk(BIOS_NOTICE,"pcie ep PERST desserted\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/feae7ee3_521649ad PS4, Line 773: if (vend_id == 0xffff || vend_id == 0x0000) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119435): https://review.coreboot.org/c/coreboot/+/53902/comment/d2880da6_9a1ba6bd PS4, Line 1140: if(!ret) space required before the open parenthesis '('