build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39178 )
Change subject: sb/amd: Move SMBus code to common place ......................................................................
Patch Set 11:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39178/11/src/southbridge/amd/common... File src/southbridge/amd/common/smbus.c:
https://review.coreboot.org/c/coreboot/+/39178/11/src/southbridge/amd/common... PS11, Line 65: printk(BIOS_DEBUG, "do_smbus_recv_byte - smbus not ready.\n"); Prefer using '"%s...", __func__' to using 'do_smbus_recv_byte', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/39178/11/src/southbridge/amd/common... PS11, Line 93: printk(BIOS_DEBUG, "do_smbus_send_byte - smbus not ready.\n"); Prefer using '"%s...", __func__' to using 'do_smbus_send_byte', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/39178/11/src/southbridge/amd/common... PS11, Line 121: printk(BIOS_DEBUG, "do_smbus_read_byte - smbus not ready.\n"); Prefer using '"%s...", __func__' to using 'do_smbus_read_byte', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/39178/11/src/southbridge/amd/common... PS11, Line 152: printk(BIOS_DEBUG, "do_smbus_write_byte - smbus not ready.\n"); Prefer using '"%s...", __func__' to using 'do_smbus_write_byte', this function's name, in a string