[coreboot-gerrit] Change in coreboot[master]: soc/amd/common/psp: Consolidate FW blob load functions

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39999 )

Change subject: soc/amd/common/psp: Consolidate FW blob load functions
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39999/1/src/soc/amd/common/block/ps... 
File src/soc/amd/common/block/psp/psp.c:

https://review.coreboot.org/c/coreboot/+/39999/1/src/soc/amd/common/block/ps... 
PS1, Line 312: (type == BLOB_SMU_FW || type == BLOB_SMU_FW2)
> i removed this now; should i add a comment about the removed additional checks that are currently al […]

Yes, I would add something.  Maybe simply a comment above line 311 that states something like "The only two currently supported types require selectable SMU firmware".  That should be sufficient to catch someone's eye later and suggest the check needs to be reworked.  I'm OK with more detail too.