Attention is currently required from: Angel Pons, Felix Held, Martin L Roth, Matt DeVillier.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78343?usp=email )
Change subject: mb/purism/librem_jsl: Add support for Librem 11
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
don't see any major issues, but if you do anticipate having another JSL variant in the future, you m […]
Thanks for the suggestion. It's hard to say whether we'll have another JSL variant. I think without knowing, it's hard to predict which aspects of the board would be shared and which would not, so even if I split this to a variant+baseboard based on a guess I'd probably end up doing a lot of refactoring when another variant exists anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78343?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I545994889ddfb41f56de09b3a42840bccbd7c4aa
Gerrit-Change-Number: 78343
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 13 Oct 2023 14:03:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment