Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47015 )
Change subject: mb/google/octopus/variants/garg: update new LTE SKU
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47015/1/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/garg/variant.c:
https://review.coreboot.org/c/coreboot/+/47015/1/src/mainboard/google/octopu...
PS1, Line 58: case SKU_39_2A2C_360_LTE_TS_STYLUES:
It would be a good time to introduce a new function of checking whether it is the SKU of LTE so two checks here and the one in gpio.c can all leverage this new function?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47015
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifec4e1360bd1aff3825bc6413b0a2ccd8b822075
Gerrit-Change-Number: 47015
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: Kevin Chiu
kevin.chiu@quanta.corp-partner.google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 30 Oct 2020 11:37:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment