4 Nov
2019
4 Nov
'19
9:31 a.m.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36603 )
Change subject: mb/*/*: Don't guard serial setup ......................................................................
Patch Set 1:
Patch Set 1:
I don't see the use case. If serial console is disable it would get initialized in ramstage. Why do it early in the boot flow if unnecessary?
How so? ramstage only initializes resources later on.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36603
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieca2ec1e376cdb26d76222126307fe016572d9d7
Gerrit-Change-Number: 36603
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 04 Nov 2019 08:31:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment