Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Subrata Banik, Varshit Pandya, Weimin Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81636?usp=email )
Change subject: mb/google/nissa/var/anraggar: Delay to deassert RST pin for TCHSCR
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81636/comment/cddd0ad6_e9c1a83e :
PS3, Line 7: Delay to deassert RST pin for TCHSCR
Please use a verb in imperative mood. Either
Add delay to …
or
Delay deassert RST pin for TCHSCR
https://review.coreboot.org/c/coreboot/+/81636/comment/2a54c18f_69d124e7 :
PS3, Line 9: Change to pull up
“Change to” is redundant in the commit message: Pull up GPP_C1 (RST pin of touchscreen) in override GPIO table instead of early GPIO table to make …
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81636?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4bd17ecf8ffbe6ca8791fa1bc4577f4dfb4ea8e8
Gerrit-Change-Number: 81636
Gerrit-PatchSet: 3
Gerrit-Owner: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Thu, 04 Apr 2024 10:19:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment