EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35881 )
Change subject: mb/google/octopus/variants/fleex: Update GPIOs to fix EMR
......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2:
(1 comment)
It add delay based on enable_delay_ms between enable and disable reset, I think we miss this in device tree. ELAN0001 and WDHT0002 have this.
Nice catch since EN_PP3300_TOUCHSCREEN control the power of stylus and if you add it as enable pin and add delay as well then it will be good to me. But curious about why without it the power of stylus is still enabled currently.
That's true and HW measure power sequence is Pass. Kind of weird.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35881
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28cef592374fb4aeee2f3d3010cc0e237d62a2fd
Gerrit-Change-Number: 35881
Gerrit-PatchSet: 2
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Jasper Lee
jasper_lee@compal.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 10 Oct 2019 04:20:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment