build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35730 )
Change subject: sb,nb/intel/fsp_rangeley: Rename from xx_DEV_FUNC ......................................................................
Patch Set 6:
(19 comments)
https://review.coreboot.org/c/coreboot/+/35730/6/src/northbridge/intel/fsp_r... File src/northbridge/intel/fsp_rangeley/fsp/chipset_fsp_util.c:
https://review.coreboot.org/c/coreboot/+/35730/6/src/northbridge/intel/fsp_r... PS6, Line 105: switch (dev->path.pci.devfn) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... File src/southbridge/intel/fsp_rangeley/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... PS6, Line 29: # define SOC_DEVFN_SOC PCI_DEVFN(SOC_DEV,SOC_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... PS6, Line 34: # define SOC_DEVFN_PCIE_PORT1 PCI_DEVFN(PCIE_PORT1_DEV,PCIE_PORT1_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... PS6, Line 39: # define SOC_DEVFN_PCIE_PORT2 PCI_DEVFN(PCIE_PORT2_DEV,PCIE_PORT2_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... PS6, Line 44: # define SOC_DEVFN_PCIE_PORT3 PCI_DEVFN(PCIE_PORT3_DEV,PCIE_PORT3_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... PS6, Line 49: # define SOC_DEVFN_PCIE_PORT4 PCI_DEVFN(PCIE_PORT4_DEV,PCIE_PORT4_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... PS6, Line 54: # define SOC_DEVFN_HOST_BRIDGE PCI_DEVFN(HOST_BRIDGE_DEV,HOST_BRIDGE_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... PS6, Line 59: # define SOC_DEVFN_RCEC PCI_DEVFN(RCEC_DEV,RCEC_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... PS6, Line 64: # define SOC_DEVFN_SMBUS1 PCI_DEVFN(SMBUS1_DEV,SMBUS1_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... PS6, Line 70: # define SOC_DEVFN_GBE1 PCI_DEVFN(GBE1_DEV,GBE1_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... PS6, Line 73: # define SOC_DEVFN_GBE2 PCI_DEVFN(GBE2_DEV,GBE2_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... PS6, Line 76: # define SOC_DEVFN_GBE3 PCI_DEVFN(GBE3_DEV,GBE3_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... PS6, Line 79: # define SOC_DEVFN_GBE4 PCI_DEVFN(GBE4_DEV,GBE4_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... PS6, Line 84: # define SOC_DEVFN_USB2 PCI_DEVFN(USB2_DEV,USB2_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... PS6, Line 89: # define SOC_DEVFN_SATA2 PCI_DEVFN(SATA2_DEV,SATA2_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... PS6, Line 94: # define SOC_DEVFN_SATA3 PCI_DEVFN(SATA3_DEV,SATA3_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... PS6, Line 102: # define SOC_DEVFN_LPC PCI_DEVFN(LPC_DEV,LPC_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... PS6, Line 108: # define SOC_DEVFN_SMBUS0 PCI_DEVFN(SMBUS0_DEV,SMBUS0_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35730/6/src/southbridge/intel/fsp_r... PS6, Line 113: # define SOC_DEVFN_IQAT PCI_DEVFN(IQAT_DEV,IQAT_FUNC) space required after that ',' (ctx:VxV)