Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32788 )
Change subject: soc/intel/common/block/gpio: Add gpio_pm_configure() function ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/32788/6/src/soc/intel/common/block/gpio/gpio... File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/#/c/32788/6/src/soc/intel/common/block/gpio/gpio... PS6, Line 625: misccfg_pm_mask[i] Shouldn't the mask be always 0x3F so that you can actually set the value (0 or 1) that is requested by mainboard?