Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37187 )
Change subject: soc/intel/{apl,cnl,dnv,skl}: Skip ucode loading by FSP-T
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37187/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37187/1//COMMIT_MSG@17
PS1, Line 17: Gen-6
Gen 4 actually.
Done
https://review.coreboot.org/c/coreboot/+/37187/1/src/soc/intel/apollolake/fs...
File src/soc/intel/apollolake/fspcar.c:
https://review.coreboot.org/c/coreboot/+/37187/1/src/soc/intel/apollolake/fs...
PS1, Line 30: whioch
which.
Done
https://review.coreboot.org/c/coreboot/+/37187/1/src/soc/intel/denverton_ns/...
File src/soc/intel/denverton_ns/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37187/1/src/soc/intel/denverton_ns/...
PS1, Line 35: CONFIG_CPU_MICROCODE_CBFS_LOC
Drop the Kconfig symbols, they are unused now?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37187
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a406fa0e2e62e3363c2960e173dc5f5f5ca0455
Gerrit-Change-Number: 37187
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Vincent Zimmer
vincent.zimmer@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 25 Nov 2019 08:03:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment