James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31363 )
Change subject: mb/gigabyte: add GA-P67A-UD3R
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31363/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31363/1//COMMIT_MSG@40
PS1, Line 40: - SATA 2
Are these untested because they broke due to the hardware bug?
They don't work in vendor BIOS, I assume this is the case.
https://review.coreboot.org/#/c/31363/1/src/mainboard/gigabyte/ga-p67a-ud3r/...
File src/mainboard/gigabyte/ga-p67a-ud3r/romstage.c:
https://review.coreboot.org/#/c/31363/1/src/mainboard/gigabyte/ga-p67a-ud3r/...
PS1, Line 65: /* Disable SIO WDT which kicks in DualBIOS */
This line looks familiar.
I'll add you to the copyright.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31363
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4fbf50376be3184bf01a3bc8aae09bce54676707
Gerrit-Change-Number: 31363
Gerrit-PatchSet: 1
Gerrit-Owner: James
jye836@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: James
jye836@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 15 Feb 2019 23:40:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment