Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32252 )
Change subject: mb/intel/icelake_rvp: Add SMI handlers
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32252/5/src/mainboard/intel/icelake...
File src/mainboard/intel/icelake_rvp/smihandler.c:
https://review.coreboot.org/c/coreboot/+/32252/5/src/mainboard/intel/icelake...
PS5, Line 23: #if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC)
do we really need to guard this ?
Yes, handlers inside uses chromeec APIs, had to guard.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32252
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc0284b99bb2f4807ff2c0ec90b316730b251ddb
Gerrit-Change-Number: 32252
Gerrit-PatchSet: 5
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 26 Jul 2019 08:04:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment