[coreboot-gerrit] Change in coreboot[master]: sc7180: Remove QcLib specific changes from CB UART

[Roja Rani Yarubandi (Code Review)]

Roja Rani Yarubandi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42095 )

Change subject: sc7180: Remove QcLib specific changes from CB UART
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42095/1/src/soc/qualcomm/sc7180/qup... 
File src/soc/qualcomm/sc7180/qupv3_config.c:

https://review.coreboot.org/c/coreboot/+/42095/1/src/soc/qualcomm/sc7180/qup... 
PS1, Line 55: 	if (protocol != SE_PROTOCOL_UART) {
> I thought all the other QUPs (SPI and I2C) are using DFSR so their frequency settings are implicitly […]

Clock team, can you comment on Julius query on DFSR?

So if the other QUPs get their frequency set by that, then the UART QUP should also have its frequency set explicitly somehow.>> was informed from previous Cheza clock POC (David Dai) that no need to configure the frequency explicitly for XO.