Attention is currently required from: David Wu, Eran Mitrani, Eric Lai, Kapil Porwal, Tarun, Tyler Wang, YH Lin.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78216?usp=email )
Change subject: mb/google/rex/var/karis: Add FAN field in fw_config
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78216/comment/18c3cfae_8907c855 :
PS5, Line 9: FAN_SETTING_1
Please elaborate what setting 1 is.
https://review.coreboot.org/c/coreboot/+/78216/comment/86951226_108c84b9 :
PS5, Line 12: TEST=emerge-rex coreboot
Do you have access to the board?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78216?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id69ec67202b5d769cd3a9a68344a6d8913ebd78b
Gerrit-Change-Number: 78216
Gerrit-PatchSet: 5
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
ericllai@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Mon, 16 Oct 2023 06:54:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment