Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41010 )
Change subject: soc/intel/common/block/tcss: Add common code support for TCSS ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41010/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41010/3//COMMIT_MSG@10 PS3, Line 10: iTBT Is this thunderbolt specific or applicable to USB4 as well?
https://review.coreboot.org/c/coreboot/+/41010/3/src/soc/intel/common/block/... File src/soc/intel/common/block/tcss/Kconfig:
https://review.coreboot.org/c/coreboot/+/41010/3/src/soc/intel/common/block/... PS3, Line 4: Intel Processor common TCSS support This option seems to be unused. Should TCSS_PCIE_SEGMENT be dependent on this Kconfig?
https://review.coreboot.org/c/coreboot/+/41010/3/src/soc/intel/common/block/... PS3, Line 6: TCSS_PCIE_SEGMENT why 'E' in PCIE? It's not necessarily pci express.