Attention is currently required from: Lance Zhao, Angel Pons. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51638 )
Change subject: ChromeOS: Separate NVS from global GNVS ......................................................................
Patch Set 5:
(4 comments)
File src/acpi/gnvs.c:
https://review.coreboot.org/c/coreboot/+/51638/comment/bc8179db_17da0b1f PS4, Line 43: chromeos_init_chromeos_acpi
Sorry gotcha. […]
Ack
File src/vendorcode/google/chromeos/gnvs.c:
https://review.coreboot.org/c/coreboot/+/51638/comment/2ba186f7_7c56377e PS4, Line 33: static __unused void chromeos_init_chromeos_acpi(void)
That's the question, should the call be inside acpi/gnvs. […]
Ack
https://review.coreboot.org/c/coreboot/+/51638/comment/3551e39a_8863328b PS4, Line 38: chromeos_acpi = cbmem_add(CBMEM_ID_ACPI_GNVS, sizeof(struct chromeos_acpi));
Needs new ID.
Done
https://review.coreboot.org/c/coreboot/+/51638/comment/7747561e_ff3b2b10 PS4, Line 96: static __unused void acpi_fill_cnvs(void)
I was thinking inside vc/google/chromeos/acpi.c:chromeos_dsdt_generator(). […]
Ack