Attention is currently required from: Lance Zhao, Angel Pons.

View Change

4 comments:

• File src/acpi/gnvs.c:

  • Patch Set #4, Line 43: chromeos_init_chromeos_acpi

    Sorry gotcha. […]

    Ack

• File src/vendorcode/google/chromeos/gnvs.c:

  • Patch Set #4, Line 33: static __unused void chromeos_init_chromeos_acpi(void)

    That's the question, should the call be inside acpi/gnvs. […]

    Ack

  • Patch Set #4, Line 38: chromeos_acpi = cbmem_add(CBMEM_ID_ACPI_GNVS, sizeof(struct chromeos_acpi));

    Needs new ID.

    Done

  • Patch Set #4, Line 96: static __unused void acpi_fill_cnvs(void)

    I was thinking inside vc/google/chromeos/acpi.c:chromeos_dsdt_generator(). […]

    Ack

To view, visit change 51638. To unsubscribe, or for help writing mail filters, visit settings.