chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37458 )
Change subject: mb/google/kahlee/treeya: Tune VIH meet spec
......................................................................
Patch Set 2:
Patch Set 1:
Patch Set 1:
Hi PeiChao,
Does it change to meet the bayhub spec? If so, I think it also can apply to other grunt followers.so you can do the change under the baseboard/mainboard.c without creating the other one.
Dear Chris, yes we follow vendor's request and this modification could be able to pass the test and meet spec. Thanks!
Hi PeiChao,
If that is bayhub's requirement, I think it should add to all grunt followers.
Would you help to apply to baseboard instead of only for treeya?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37458
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4de9e6cfb37e3b76f7afc206cbe3396b8da2d6dd
Gerrit-Change-Number: 37458
Gerrit-PatchSet: 2
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: chris wang
Chris.Wang@amd.com
Gerrit-Comment-Date: Wed, 04 Dec 2019 07:19:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment