Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31317 )
Change subject: google/kahlee: No need to guard with HAVE_ACPI_RESUME ......................................................................
Patch Set 1: Code-Review-1
For the same reason as the previous review, I would prefer you abandon this unless you first block the capability to enter S3. Also, I should soon release a new board using a variation of stoneyridge code (to support merlin falcon). S3 is a lot more complicated then you imagine, and some of these code was not part of original S3, but fix to S3 bugs. However, AMD gardenia (as far as I remember) do not support S3 and don't have this code. If you play with S3 control without first being sure that S3 entry is avoided when S3 is disabled, all sort of bad things could happen. True, all kahlee based platforms will have S3 enabled... but what if someone wants to create new board, based on kahlee (want some of kahlee characteristics but not S3)? Though not as serious as one within agesawrapper, I would not play with S3 code. The amount of bugs we had to fix on S3 code is not worth risking creating new bugs. If you want to continue with this, at least add a message to this effect warning any OEM using kahlee folder as a base for a new project on what is needed if he/she does not want S3.