Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34882 )
Change subject: arch/x86: Move stack with CAR_GLOBAL_MIGRATION
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34882/2/src/arch/x86/car.ld
File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/34882/2/src/arch/x86/car.ld@43
PS2, Line 43: #if !CONFIG(CAR_GLOBAL_MIGRATION)
: _car_stack_start = .;
: . += CONFIG_DCACHE_BSP_STACK_SIZE;
: _car_stack_end = .;
: #endif
This can definitely goes wrong if platforms were in fact using more than the default CONFIG_DCACHE_BSP_STACK_SIZE...
It might be worth adding a check with -fstack-usage against CONFIG_DCACHE_BSP_STACK_SIZE at compiletime.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34882
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58d50c6f8f922c9e8664698d77836cac2c13b126
Gerrit-Change-Number: 34882
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 18 Aug 2019 07:17:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment