[coreboot-gerrit] Change in coreboot[master]: nb/amd/agesa: select ROMSTAGE_CACHED_CBMEM

[Mike Banon (Code Review)]

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37198 )

Change subject: nb/amd/agesa: select ROMSTAGE_CACHED_CBMEM
......................................................................


Patch Set 7:
> Patch Set 7:
> > Patch Set 7:
> > > Patch Set 7:
> > >
> > > While building for G505S (15h) I got:
> > >
> > > CC         romstage/southbridge/amd/agesa/hudson/smbus.o
> > >     CC         romstage/southbridge/amd/agesa/hudson/smbus_spd.o
> > >     CC         romstage/vendorcode/amd/agesa/common/agesa-entry.o
> > >     LINK       cbfs/fallback/romstage.debug
> > >     OBJCOPY    cbfs/fallback/romstage.elf
> > > make: *** No rule to make target '".car.data"', needed by 'build/coreboot.pre'.  Stop.
> > >
> > > But that's maybe because I selected a "Compress postcar with LZ4 (COMPRESS_POSTCAR) [Y/n/?] (NEW) y". Now will try without it
> >
> > Either downgrade to make or apply https://review.coreboot.org/c/coreboot/+/38790
>
> Board boots fine until SeaBIOS, then I don't get any graphics in Linux. Here's my coreboot boot log captured with FT232H adapter - https://pastebin.com/g3LyVBZx . Maybe it's just an unfortunate parent  of this change and the change itself is fine. Please rebase this change series on top of a stable commit like e6fb1344ed9188e19be4b54bdf1a76680b8c4523 or master (if it's okay currently), then I could retest this. Meanwhile, need to unbrick a laptop...

On weekends I have some time for unbricking, so if you have new ideas about how to make this change bootable - please go ahead, and I'll test again happily.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/37198
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62ffe1bd646e9ddad77be240f030601790f4da4b
Gerrit-Change-Number: 37198
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Michał Żygowski <[e-mail]>
Gerrit-Reviewer: Mike Banon <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Reviewer: wrong ID - Marshall Dawson <[e-mail]>
Gerrit-CC: Krystian Hebel <[e-mail]>
Gerrit-CC: Kyösti Mälkki <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Sun, 07 Jun 2020 12:59:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment