Patch Set 7:

Patch Set 7:

Patch Set 7:

While building for G505S (15h) I got:

    CC         romstage/southbridge/amd/agesa/hudson/smbus.o
CC romstage/southbridge/amd/agesa/hudson/smbus_spd.o
CC romstage/vendorcode/amd/agesa/common/agesa-entry.o
LINK cbfs/fallback/romstage.debug
OBJCOPY cbfs/fallback/romstage.elf
make: *** No rule to make target '".car.data"', needed by 'build/coreboot.pre'. Stop.

But that's maybe because I selected a "Compress postcar with LZ4 (COMPRESS_POSTCAR) [Y/n/?] (NEW) y". Now will try without it

Either downgrade to make or apply https://review.coreboot.org/c/coreboot/+/38790

Board boots fine until SeaBIOS, then I don't get any graphics in Linux. Here's my coreboot boot log captured with FT232H adapter - https://pastebin.com/g3LyVBZx . Maybe it's just an unfortunate parent of this change and the change itself is fine. Please rebase this change series on top of a stable commit like e6fb1344ed9188e19be4b54bdf1a76680b8c4523 or master (if it's okay currently), then I could retest this. Meanwhile, need to unbrick a laptop...

On weekends I have some time for unbricking, so if you have new ideas about how to make this change bootable - please go ahead, and I'll test again happily.

View Change

To view, visit change 37198. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62ffe1bd646e9ddad77be240f030601790f4da4b
Gerrit-Change-Number: 37198
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: wrong ID - Marshall Dawson <marshall.dawson@amd.corp-partner.google.com>
Gerrit-CC: Krystian Hebel <krystian.hebel@3mdeb.com>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sun, 07 Jun 2020 12:59:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment