Attention is currently required from: Alexander Couzens, Patrick Rudolph, amersel.
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52659 )
Change subject: mb/lenovo/w541: Add Lenovo Thinkpad W541
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/lenovo/w541/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/52659/comment/ed4a20fa_ffb57439
PS8, Line 8: .up_delay_ms = 2000,
I'm afraid these values are wrong. I've recalculated them and I believ they should be
register "panel_cfg" = "{
.up_delay_ms = 200,
.down_delay_ms = 50,
.cycle_delay_ms = 500,
.backlight_on_delay_ms = 1,
.backlight_off_delay_ms = 1,
.backlight_pwm_hz = 220,
}"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52659
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08
Gerrit-Change-Number: 52659
Gerrit-PatchSet: 8
Gerrit-Owner: amersel
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: amersel
Gerrit-Comment-Date: Wed, 28 Apr 2021 17:12:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment