Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36609 )
Change subject: mb/google/hatch/variants/helios: Update TSR3 sensor thresholds ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36609/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36609/2/src/mainboard/google/hatch/... PS2, Line 39: #define DPTF_TSR3_PASSIVE 90 : #define DPTF_TSR3_CRITICAL 105 : #define DPTF_TSR3_ACTIVE_AC0 87 : #define DPTF_TSR3_ACTIVE_AC1 85 : #define DPTF_TSR3_ACTIVE_AC2 83 : #define DPTF_TSR3_ACTIVE_AC3 80 : #define DPTF_TSR3_ACTIVE_AC4 78 : #define DPTF_TSR3_ACTIVE_AC5 75
I thought when the thresholds were set to 0, that meant the the particular threshold was not used? […]
These are temperature thresholds values. When these are set to 0, it means when current TSR3 sensor temperature above 0 as per below DART at line 102, fan will start running as per 30 value. This means once system starts/boots TSR3 sensor temperature will be always above 0 degree and fan will be always running. 5 degree change in both _PASSIVE and _CRITICAL are initial values, we might need to fine tune on DVT systems once available.