Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35585 )
Change subject: soc/intel/fsp_broadwell_de: move get_busno1() into vtd.c
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35585/1/src/soc/intel/fsp_broadwell...
File src/soc/intel/fsp_broadwell_de/vtd.c:
https://review.coreboot.org/c/coreboot/+/35585/1/src/soc/intel/fsp_broadwell...
PS1, Line 52: int8_t get_busno1(void)
: {
: uint32_t reg32;
:
: /* Figure out what bus number is assigned for CPUBUSNO(1) */
: reg32 = pci_mmio_read_config32(VTD_PCI_DEV, VTD_CPUBUSNO);
: return ((reg32 >> VTD_CPUBUSNO_BUS1_SHIFT) & VTD_CPUBUSNO_BUS1_MASK);
: }
because we are reading this register from VTD device not UBOX device
I see, fine for me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35585
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34aee507b8c322c816f92cfcae177c069c749ed7
Gerrit-Change-Number: 35585
Gerrit-PatchSet: 1
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Sep 2019 04:44:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Comment-In-Reply-To: Andrey Petrov
anpetrov@fb.com
Gerrit-MessageType: comment