Attention is currently required from: Furquan Shaikh, Martin Roth, Duncan Laurie. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52747 )
Change subject: util/sconfig: Add support for discontiguous FW_CONFIG fields ......................................................................
Patch Set 4:
(44 comments)
File util/sconfig/lex.yy.c_shipped:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/99948b10_ad407cb6 PS4, Line 34: * if you want the limit (max/min) macros for int types. trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/05ca9410_e2874cb1 PS4, Line 51: typedef unsigned char flex_uint8_t; trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/e01cc68f_d91bccaa PS4, Line 162: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/09f889d4_aed716b1 PS4, Line 165: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/5a20ce93_86aa9b1d PS4, Line 641: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/a42e41f1_73959205 PS4, Line 643: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/01e41a5e_8d342166 PS4, Line 770: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/35576986_c5803d53 PS4, Line 1344: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/f6968f82_e06ccef7 PS4, Line 1400: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/0adbbeb2_27eb1363 PS4, Line 1445: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/e772a881_854b6e42 PS4, Line 1512: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/f9ed9110_ddd38e36 PS4, Line 1517: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/1af3110a_79e3c5d6 PS4, Line 1530: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/ce304caf_8a9f9ad1 PS4, Line 1534: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/4946fccd_3a604783 PS4, Line 1574: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/b71cdb9a_f499cd81 PS4, Line 1580: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/0c6478e6_d11208c4 PS4, Line 1603: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/734b9e4a_70010dca PS4, Line 1607: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/8ffcb3df_fde67d8c PS4, Line 1628: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/ddb12524_82fe1280 PS4, Line 1644: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/f04c09a0_e47f9e26 PS4, Line 1650: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/ae353652_d7e23f3b PS4, Line 1679: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/66f1a0c2_66d87d3d PS4, Line 1709: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/fe1fe4b4_1a65a60d PS4, Line 1733: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/5b1cad19_742b4eb9 PS4, Line 1776: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/7d62cff7_49121bd7 PS4, Line 1782: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/bf89fd23_3c1504a4 PS4, Line 1811: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/4c12cef2_1fc32ed2 PS4, Line 1818: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/f9b1c31b_7704c079 PS4, Line 1826: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/651de369_16ec87b9 PS4, Line 1835: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/2514595a_d2b87c46 PS4, Line 1889: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/0a85e3b1_2029f717 PS4, Line 1893: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/d9aa8411_0be05b88 PS4, Line 1898: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/2dca5332_408fb240 PS4, Line 1906: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/59ac6e56_b448278f PS4, Line 1914: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/eb03eb9e_8d8ff064 PS4, Line 1922: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/5254c37b_6af59404 PS4, Line 1932: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/e226b96e_0e36fe2a PS4, Line 1936: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/24b555e5_46a21b57 PS4, Line 1943: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/70c00686_3152d065 PS4, Line 1997: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/289fe26f_6a719309 PS4, Line 2023: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/6f2aad2f_da6d64e4 PS4, Line 2048: trailing whitespace
File util/sconfig/main.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/4e2f5e6f_39d02969 PS4, Line 453: printf("ERROR: fw_config field %s has invalid range %u-%u\n", field->name, line over 96 characters
File util/sconfig/sconfig.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118065): https://review.coreboot.org/c/coreboot/+/52747/comment/1a419cd0_7975a3b3 PS4, Line 223: struct fw_config_field *new_fw_config_field(const char *name, struct fw_config_field_bits *bits); line over 96 characters