Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/57219 )
Change subject: drivers/intel/fsp/Makefile: error out when FSP files aren't specified ......................................................................
drivers/intel/fsp/Makefile: error out when FSP files aren't specified
Error out when the FSP binaries that are supposed to be added aren't specified.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Suggested-by: Nico Huber nico.h@gmx.de Change-Id: Ie5f2d75d066f0b4e491e9c8420b7a0cbd4ba9e28 Reviewed-on: https://review.coreboot.org/c/coreboot/+/57219 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/drivers/intel/fsp2_0/Makefile.inc 1 file changed, 15 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Nico Huber: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/drivers/intel/fsp2_0/Makefile.inc b/src/drivers/intel/fsp2_0/Makefile.inc index b472721..80dc93b 100644 --- a/src/drivers/intel/fsp2_0/Makefile.inc +++ b/src/drivers/intel/fsp2_0/Makefile.inc @@ -97,6 +97,21 @@ CPPFLAGS_common+=-I$(CONFIG_FSP_HEADER_PATH) endif
+# check if the FSP files that are supposed to be added are specified +ifeq ($(CONFIG_ADD_FSP_BINARIES),y) +ifeq ($(CONFIG_FSP_CAR),y) +ifeq ($(call strip_quotes,$(CONFIG_FSP_T_FILE)),) +$(error No FSP-T binary file specified.) +endif # CONFIG_FSP_T_FILE +endif # CONFIG_FSP_CAR +ifeq ($(call strip_quotes,$(CONFIG_FSP_M_FILE)),) +$(error No FSP-M binary file specified.) +endif # CONFIG_FSP_M_FILE +ifeq ($(call strip_quotes,$(CONFIG_FSP_S_FILE)),) +$(error No FSP-S binary file specified.) +endif # CONFIG_FSP_S_FILE +endif # CONFIG_ADD_FSP_BINARIES + subdirs-y += ppi
endif