build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46566 )
Change subject: mb/google/zork: Fix get board version and get fw config issue
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46566/2/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/baseboard/helpers.c:
https://review.coreboot.org/c/coreboot/+/46566/2/src/mainboard/google/zork/v...
PS2, Line 98: if (google_chromeec_cbi_get_board_version(&board_version) !=0)
spaces required around that '!=' (ctx:WxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46566
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia49ac1ee35302f8f6afe8c0eb8e13afdf36c5b2b
Gerrit-Change-Number: 46566
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 19 Oct 2020 18:56:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment