Attention is currently required from: Dinesh Gehlot, Tim Wawrzynczak.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/82138?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: gma pipe_setup: Update for TGL & ADL ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File common/hw-gfx-gma-pipe_setup.adb:
https://review.coreboot.org/c/libgfxinit/+/82138/comment/a67a9369_270c3bae : PS1, Line 234: 1 Looks like the value used here is dependent on plane state:
https://github.com/torvalds/linux/blob/ed30a4a51bb196781c8058073ea720133a655... https://github.com/torvalds/linux/blob/ed30a4a51bb196781c8058073ea720133a655...
Is it OK to hardcode `1` here? If so, why?
https://review.coreboot.org/c/libgfxinit/+/82138/comment/5fb800a0_7312069d : PS1, Line 341: if Config.Has_New_Mbus_Dbox_Credits then Where is this procedure described? The only procedure in i915 that seems to use these registers is this: https://github.com/torvalds/linux/blob/ed30a4a51bb196781c8058073ea720133a655...
Looks like these steps are only applied when some conditions are met. I guess it doesn't matter much for us; we can set these bits once and call it a day.
Given the WA name (`Wa_22010947358:adl-p`), one may think this is only for ADL-P. But i915 only distinguishes between ADL-P and ADL-S, so I believe `Has_New_Mbus_Dbox_Credits` has the right value.
What I don't know is whether we can forget about `joined_mbus`.