Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46391 )
Change subject: mb/google/asurada: Get RAM code from ADC 3
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46391/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46391/4//COMMIT_MSG@9
PS4, Line 9: Mapping the voltage of AUX_IN3 to ram id.
Where is the map documented?
Ack
https://review.coreboot.org/c/coreboot/+/46391/4//COMMIT_MSG@7
PS4, Line 7: b/google/asurada: Get ram id from AUX_IN3
:
: Mapping the voltage of AUX_IN3 to ram id.
Maybe change to: […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46391
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaadabea1b6aa91c48b137f7c6784ab7ee0adc473
Gerrit-Change-Number: 46391
Gerrit-PatchSet: 8
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 23 Oct 2020 09:35:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment