Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34459 )
Change subject: payloads/tianocore: Enable UEFIPayload ......................................................................
Patch Set 12:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34459/11/payloads/external/Makefile... File payloads/external/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34459/11/payloads/external/Makefile... PS11, Line 131: CONFIG_TIANOCORE_MASTER=$(CONFIG_TIANOCORE_MASTER) \ : CONFIG_TIANOCORE_STABLE=$(CONFIG_TIANOCORE_STABLE) \ : CONFIG_TIANOCORE_REVISION=$(CONFIG_TIANOCORE_REVISION) \
drop these
Done
https://review.coreboot.org/c/coreboot/+/34459/11/payloads/external/tianocor... File payloads/external/tianocore/Kconfig:
https://review.coreboot.org/c/coreboot/+/34459/11/payloads/external/tianocor... PS11, Line 33: config TIANOCORE_STABLE : bool "stable" : depends on TIANOCORE_COREBOOTPAYLOAD : help : Select this option to build using MrChromebox's custom Tianocore tree : i.e. a version of Tianocore that builds without any errors and just works. : : config TIANOCORE_MASTER : bool "master" : depends on TIANOCORE_UEFIPAYLOAD : help : Select this option if you have a specific commit or branch : that you want to build Tianocore. : : You will be able to specify the name of a branch or a commit id : later.
we can actually drop these, since not being used in a choice, and default branches are set in the ma […]
Done
https://review.coreboot.org/c/coreboot/+/34459/11/payloads/external/tianocor... PS11, Line 105: depends on TIANOCORE_STABLE
drop here too
Done
https://review.coreboot.org/c/coreboot/+/34459/11/payloads/external/tianocor... File payloads/external/tianocore/Makefile:
https://review.coreboot.org/c/coreboot/+/34459/11/payloads/external/tianocor... PS11, Line 26: bootloader=UefiPayloadPkg : build_flavor=-D BOOTLOADER=COREBOOT -D PCIE_BASE=$(CONFIG_MMCONF_BASE_ADDRESS)
add: […]
Done
https://review.coreboot.org/c/coreboot/+/34459/11/payloads/external/tianocor... PS11, Line 31: TAG-$(CONFIG_TIANOCORE_STABLE)=origin/$(project_git_branch)
change to tag-y
I changed to tag directly, seems there's no more need for -y anymore as that's always selected.