Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45214 )
Change subject: trogdor/sc7180: Clarify USE_QC_BLOBS requirements ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45214/3/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/45214/3/src/mainboard/google/trogdo... PS3, Line 3: if USE_QC_BLOBS this is not something that should be in Kconfig.name and also breaks Kconfig:
c0d3@z3r0:[~/src/coreboot.git]# make oldconfig src/mainboard/google/asurada/Kconfig:13:error: recursive dependency detected! src/mainboard/google/asurada/Kconfig:13: symbol BOARD_SPECIFIC_OPTIONS depends on BOARD_GOOGLE_ASURADA_COMMON src/mainboard/google/asurada/Kconfig:4: symbol BOARD_GOOGLE_ASURADA_COMMON is selected by BOARD_GOOGLE_ASURADA src/mainboard/google/asurada/Kconfig.name:3: symbol BOARD_GOOGLE_ASURADA is part of choice <choice> src/mainboard/google/Kconfig:5: choice <choice> contains symbol BOARD_GOOGLE_BUBS src/mainboard/google/trogdor/Kconfig.name:5: symbol BOARD_GOOGLE_BUBS depends on USE_QC_BLOBS src/Kconfig:237: symbol USE_QC_BLOBS depends on USE_BLOBS src/Kconfig:215: symbol USE_BLOBS is selected by BOARD_SPECIFIC_OPTIONS # # configuration written to /home/c0d3/src/coreboot.git/.config # src/mainboard/google/asurada/Kconfig:13:error: recursive dependency detected! src/mainboard/google/asurada/Kconfig:13: symbol BOARD_SPECIFIC_OPTIONS depends on BOARD_GOOGLE_ASURADA_COMMON src/mainboard/google/asurada/Kconfig:4: symbol BOARD_GOOGLE_ASURADA_COMMON is selected by BOARD_GOOGLE_ASURADA src/mainboard/google/asurada/Kconfig.name:3: symbol BOARD_GOOGLE_ASURADA is part of choice <choice> src/mainboard/google/Kconfig:5: choice <choice> contains symbol BOARD_GOOGLE_BUBS src/mainboard/google/trogdor/Kconfig.name:5: symbol BOARD_GOOGLE_BUBS depends on USE_QC_BLOBS src/Kconfig:237: symbol USE_QC_BLOBS depends on USE_BLOBS src/Kconfig:215: symbol USE_BLOBS is selected by BOARD_SPECIFIC_OPTIONS