John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45627 )
Change subject: superio/common: Fix NULL pointer dereferences ......................................................................
superio/common: Fix NULL pointer dereferences
Coverity detects the dev->link_list NULL pointer dereferences while calling report_resource_stored. Add sanity check for dev->link_list to prevent NULL pointer dereference.
Found-by: Coverity CID 1419488 TEST=None
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I953a6524fff509a7833896392b25a3245c8cd705 --- M src/superio/common/generic.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/45627/1
diff --git a/src/superio/common/generic.c b/src/superio/common/generic.c index 83f2fea..50db688 100644 --- a/src/superio/common/generic.c +++ b/src/superio/common/generic.c @@ -20,7 +20,8 @@ continue;
res->flags |= IORESOURCE_STORED; - report_resource_stored(dev, res, ""); + if (dev->link_list) + report_resource_stored(dev, res, ""); } }