[coreboot-gerrit] Change in coreboot[master]: mb/google/delbin: Configure DP_HPD as PAD_NC and disable DdiPortHpd

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45031 )

Change subject: mb/google/delbin: Configure DP_HPD as PAD_NC and disable DdiPortHpd
......................................................................

mb/google/delbin: Configure DP_HPD as PAD_NC and disable DdiPortHpd

GPP_A19(DP_HPD1) and GPP_A20(DP_HPD2) were configured native function
(NF1) without internal pull-down which wrongly presents HPD interrupts.
DP_HPD had been removed for EVT design as those events are through eSPI.
This change configures GPP_A19 and GPP_A20 to be no connection and
disables DdiPort1Hpd and DdiPort2Hpd.

BUG=b:162566436
TEST=Booted to kernel and verified no kernel HPD pins assertion message
on Delbin board.

Signed-off-by: Ravi Sarawadi 
Change-Id: Ifdef8ee438276678258b75d2fb70c6dfc7ee0a33
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45031
Tested-by: build bot (Jenkins) 
Reviewed-by: Caveh Jalali 
---
M src/mainboard/google/volteer/variants/delbin/gpio.c
M src/mainboard/google/volteer/variants/delbin/overridetree.cb
2 files changed, 5 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Caveh Jalali: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/variants/delbin/gpio.c b/src/mainboard/google/volteer/variants/delbin/gpio.c
index 1d4bfe6..5748bb3 100644
--- a/src/mainboard/google/volteer/variants/delbin/gpio.c
+++ b/src/mainboard/google/volteer/variants/delbin/gpio.c
@@ -19,9 +19,9 @@
    /* A18 : DDSP_HPDB ==> HDMI_HPD */
    PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1),
    /* A19 : DDSP_HPD1 ==> USB_C0_DP_HPD */
-	PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1),
+	PAD_NC(GPP_A19, NONE),
    /* A20 : DDSP_HPD2 ==> USB_C1_DP_HPD */
-	PAD_CFG_NF(GPP_A20, NONE, DEEP, NF1),
+	PAD_NC(GPP_A20, NONE),
    /* A22 : DDPC_CTRLDATA ==> EN_HDMI_PWR */
    PAD_CFG_GPO(GPP_A22, 1, DEEP),
    /* A23 : I2S1_SCLK ==> I2S1_SPKR_SCLK */
diff --git a/src/mainboard/google/volteer/variants/delbin/overridetree.cb b/src/mainboard/google/volteer/variants/delbin/overridetree.cb
index fc549c7..05c8a34 100644
--- a/src/mainboard/google/volteer/variants/delbin/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/delbin/overridetree.cb
@@ -1,4 +1,7 @@
 chip soc/intel/tigerlake
+	register "DdiPort1Hpd" = "0"
+	register "DdiPort2Hpd" = "0"
+
    device domain 0 on
    	device pci 15.0 on
    		chip drivers/i2c/generic