Attention is currently required from: David Wu, Tarun Tuli, Kangheui Won, Ren Kuo, Reka Norman, Vidya Gopalakrishnan, Sumeet R Pawnikar, Tyler Wang, Peter Ou.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71860 )
Change subject: mb/google/nissa/var/craask: Modify DPTF settings
......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71860/comment/cf442333_7e583977
PS5, Line 9: Craasneto
Shouldn’t that be mentioned in the prefix?
https://review.coreboot.org/c/coreboot/+/71860/comment/cae7c824_b5edc1bb
PS5, Line 9: Limit(PL)
Please add a space before the (.
https://review.coreboot.org/c/coreboot/+/71860/comment/c6c98859_61eaf879
PS5, Line 9: Add ADL-N 15W CPU Power Limit(PL) settings for Craasneto
Where did you get the new information from?
File src/mainboard/google/brya/variants/craask/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/71860/comment/16b13595_34db7951
PS5, Line 25: option THERMAL_SOLUTION_15W 1
Where is that field defined or used? I am not finding it in the current source code of origin/master (commit b63eb4d172 (crossgcc: Upgrade LLVM version 15.0.6 to 15.0.7)).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71860
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I325704d6fc4ddaf56eaddd6a69bc619588df99cd
Gerrit-Change-Number: 71860
Gerrit-PatchSet: 5
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Peter Ou
peter.ou@quanta.corp-partner.google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Vidya Gopalakrishnan
vidya.gopalakrishnan@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Vidya Gopalakrishnan
vidya.gopalakrishnan@intel.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Peter Ou
peter.ou@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 Feb 2023 08:19:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment