Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34634 )
Change subject: drivers/vpd: add framework to search VPD in romstage ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd_premem... File src/drivers/vpd/vpd_premem.c:
https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd_premem... PS10, Line 78: struct vpd_blob *blob = car_get_var_ptr(&g_vpd_blob); : if (!blob) : return; if we're already using car, why not just make calling vpd_load_blob automatically inside vpd_get_buffers? Then callers don't need to call vpd_load_blob explicitly, more like ram stage.