Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45811 )
Change subject: mb/google/kukui: Support SKU from camera EEPROM ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45811/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/c/coreboot/+/45811/2/src/mainboard/google/kukui/... PS2, Line 142: check_cros_camera_info
this is defined in chromeos/Makefile.inc, which will be processed only by rule […]
When CONFIG(BOARD_GOOGLE_KODAMA), shouldn't CONFIG(CHROMEOS) also be 1? I can run
util/abuild/abuild -c max -t GOOGLE_KODAMA -x
locally without errors. The '-x' option of abuild will set CONFIG_CHROMEOS=y, so I wonder why we got this error. From the log, I can't tell if the error comes from [1] or other lines.
[1] https://github.com/coreboot/coreboot/blob/6e8d38ec4e6a5a89e1bf6cec611d5bf8d4...