28 Jul
2021
28 Jul
'21
6:05 a.m.
Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Angel Pons. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56628 )
Change subject: arch/x86: Add missing SPD memory type 72b-SO-UDIMM and Non-DIMM ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/include/spd.h:
https://review.coreboot.org/c/coreboot/+/56628/comment/cfc08bf9_4f2fafe2 PS4, Line 209: SPD_MEM_DOWN Probably use SPD_NON_DIMM just to align the name as used in JEDEC spec?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56628
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia337ac8f50b61ae78d86a07c7a86aa9c248bad50
Gerrit-Change-Number: 56628
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 28 Jul 2021 06:05:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment