Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39390 )
Change subject: cbfstool: Build vboot library
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39390/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39390/4//COMMIT_MSG@11
PS4, Line 11: will breaks
*breaks* or *will break*
Done
https://review.coreboot.org/c/coreboot/+/39390/4//COMMIT_MSG@13
PS4, Line 13: Therefore, this patch creates a new target $(VBOOT_LIB) and includes it
Please add exactly one blank line between paragraphs.
It's the same paragraph, with "Therefore" unable to fit in the previous line.
https://review.coreboot.org/c/coreboot/+/39390/4/util/cbfstool/Makefile.inc
File util/cbfstool/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39390/4/util/cbfstool/Makefile.inc@...
PS4, Line 143: VBOOT2="y" \
Pretty sure this doesn't do anything anymore and can be removed both here and from the firmware part […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39390
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc826896d895f53d69ea559a88f75672c2ec3146
Gerrit-Change-Number: 39390
Gerrit-PatchSet: 5
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 16 Mar 2020 08:48:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment