Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62618 )
Change subject: sb/intel/i82801dx/pci.c: Use pci_update_config16() and defined macros ......................................................................
sb/intel/i82801dx/pci.c: Use pci_update_config16() and defined macros
Signed-off-by: Elyes Haouas ehaouas@noos.fr Change-Id: I658fa9cee4517b9f68102b74949d32d7ab0309f8 --- M src/southbridge/intel/i82801dx/pci.c 1 file changed, 1 insertion(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/62618/1
diff --git a/src/southbridge/intel/i82801dx/pci.c b/src/southbridge/intel/i82801dx/pci.c index ee4047f..554168e 100644 --- a/src/southbridge/intel/i82801dx/pci.c +++ b/src/southbridge/intel/i82801dx/pci.c @@ -8,13 +8,8 @@
static void pci_init(struct device *dev) { - /* Enable pci error detecting */ - uint32_t dword; /* System error enable */ - dword = pci_read_config32(dev, 0x04); - dword |= (1 << 8); /* SERR# Enable */ - dword |= (1 << 6); /* Parity Error Response */ - pci_write_config32(dev, 0x04, dword); + pci_update_config16(dev, PCI_COMMAND, PCI_COMMAND_SERR | PCI_COMMAND_PARITY); }
static struct device_operations pci_ops = {