Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38150 )
Change subject: sb/intel/common: Replace inb/outb()
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38150/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38150/2//COMMIT_MSG@9
PS2, Line 9: At least since ICH10 SMBUS controller implements register
I'm not sure if I follow. I would rephrase this as:
sb/intel/common/smbus.c: Wrap inb/outb()
On Intel, accessing the SMBus register banks can be done via IO and, since at least ICH10, via MMIO. We may want to use the latter in the future.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38150
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67fcbc7b6f6be61c93bc608e556a577ef9e52325
Gerrit-Change-Number: 38150
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 08 Jan 2020 15:38:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment